Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix misleading warning/error message #165

Merged
merged 3 commits into from
Feb 17, 2025
Merged

fix misleading warning/error message #165

merged 3 commits into from
Feb 17, 2025

Conversation

dominikwelke
Copy link
Contributor

PR to update the warning and error message.
please have a look if this is alright @effigies

closes #161

@effigies
Copy link
Contributor

Thanks! Would you mind adding a changelog entry? Using scriv you can add a quick note about the fix.

If you have pipx or uv installed:

pipx run scriv create --edit


uvx scriv create --edit

@dominikwelke
Copy link
Contributor Author

like this?

@rwblair rwblair merged commit c28e802 into bids-standard:main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CLI version] wrong TSV_VALUE_INCORRECT_TYPE_NONREQUIRED warning for datatime str
3 participants
@dominikwelke @effigies @rwblair