fix: Correct Uint8Array / DataView usage for TypeScript 5.7 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a few more fixes... |
|
Doesn't seem to have done the job. Will this continue to work with older deno versions, or will this set a lower bound? |
nellh
force-pushed
the
array-buffer-fix
branch
from
827b74b to
22bc4a3
Compare
effigies
reviewed
Feb 21, 2025
nellh
force-pushed
the
array-buffer-fix
branch
from
22bc4a3 to
48987f0
Compare
effigies
approved these changes
Feb 21, 2025
It will only set the lower bound for tests or running with --check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno 2.2 via TypeScript 5.7 made typed arrays generic. Specifying the generic for Uint8Array and DataView resolves failures seen in #166.
@effigies I think this is the better alternative to #167.