Provide tool to build and distribute deno-compiled binary on PyPi #181
Conversation
The tool, including the accompanying GH Action workflow would wrap the deno-compiled binary of the BIDS validator in wheels for different platforms and publish them on PyPi.
candleindark
force-pushed
the
deno-binary
branch
9 times, most recently
from
2470c52 to
6dcbe08
Compare
candleindark
force-pushed
the
deno-binary
branch
from
6dcbe08 to
64990cf
Compare
| if git describe | grep -e -; then | ||
| echo not releasing; | ||
| else | ||
| twine upload --verbose --repository testpypi dist/*.whl |
There was a problem hiding this comment.
potentially auth could be replaced by using "trusted repositories" setup on pypi.
| push: | ||
| branches: | ||
| - main | ||
| - deno-binary |
There was a problem hiding this comment.
eventually remove
| - deno-binary |
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - deno-binary |
There was a problem hiding this comment.
overall here aim for the same setup of on as in https://github.com/bids-standard/bids-validator/blob/main/.github/workflows/deno_tests.yml
| on: | |
| push: | |
| branches: | |
| - main | |
| - deno-binary | |
| on: | |
| push: | |
| branches: [main, dev] | |
| tags: ['*'] | |
| pull_request: | |
| branches: [main, dev] |
and then add corresponding if below for twine call:
| name: wheel-${{ matrix.os }} | ||
| path: tools/pypi-whl/dist/*.whl | ||
| - name: Publish wheels if corresponds to a tag | ||
| # TODO: might be suboptimal since we might skip a tag if not the latest commit |
There was a problem hiding this comment.
| # TODO: might be suboptimal since we might skip a tag if not the latest commit | |
| if: github.ref_type == 'tag' |
| # if a clean tag, no - in it | ||
| if git describe | grep -e -; then | ||
| echo not releasing; | ||
| else | ||
| twine upload --verbose --repository testpypi dist/*.whl |
There was a problem hiding this comment.
with above if we likely do not need this
| # if a clean tag, no - in it | |
| if git describe | grep -e -; then | |
| echo not releasing; | |
| else | |
| twine upload --verbose --repository testpypi dist/*.whl | |
| twine upload --verbose --repository testpypi dist/*.whl |
|
The You need to get back to the |
|
right, somehow that got lost I guess -- may be pdm is not executed within the folder where that pdb_build.py is? Please add testing that whl files have |
|
Oh, I see. It reports using |
|
I tried to use the pdm frontend to invoke the build locally. It didn't work for me. Just use |
candleindark
force-pushed
the
deno-binary
branch
from
a46b1f1 to
4a58063
Compare
This PR closes #148. Please see commit messages for details.
Note:
--allow-runoption is used to compiled the BIDS validator from local source. Without this option, the compilation result would require the user to grant permission to run subprocesses. This option was not used/needed when compiling from the published jsr package from some reason.TODOs: