-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report warning instead of error if only warnings are returned by hed-validator #1158
Report warning instead of error if only warnings are returned by hed-validator #1158
Conversation
…validator The existing implementation errors out even if only warnings are issued by hed-validator. This is not desirable, and has been fixed here. A new issue code has been added, and a new test case has also been added, though it will not be correct until another change is made upstream.
… fix-sidecar-issue-reporting
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
+ Coverage 79.21% 79.23% +0.02%
==========================================
Files 78 78
Lines 2593 2601 +8
Branches 592 594 +2
==========================================
+ Hits 2054 2061 +7
Misses 400 400
- Partials 139 140 +1
Continue to review full report at Codecov.
|
@happy5214 can you double check my work on the HED issue numbers, due to recent merge I moved them down, wanted to make sure the issue codes in the tests match the correct error messages. Might of been hasty with the merge. |
@rwblair Sorry for the late reply. Issue code 209 and 210 were indeed flipped (the error was before the warning in the original, and the issue codes in the actual code reflect that), so that needs to be fixed. |
The sidecar warning and error codes were inadvertently flipped in the process of writing bids-standard#1158. This rectifies this error.
Correct issue code problems from #1158
The sidecar warning and error codes were inadvertently flipped in the process of writing bids-standard#1158. This rectifies this error.
The existing implementation errors out even if only warnings are issued
by hed-validator. This is not desirable, and has been fixed here. A
new issue code has been added, and a new test case has also been added,
though it will not be correct until another change is made upstream.
This is of relatively high severity, as it prevents OpenNeuro from properly validating
any BIDS datasets with HED tag extensions in the sidecar, which generate warnings.