Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: support eslint@9 #18

Merged
merged 2 commits into from
Jul 22, 2024
Merged

deps: support eslint@9 #18

merged 2 commits into from
Jul 22, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Apr 8, 2024

This adds support for eslint@9, and updates eslint-plugin-react to the version which supports eslint@9.
Node versions in the CI jobs are also updated to mitigate CI failure (https://github.com/bpmn-io/eslint-plugin-bpmn-io/actions/runs/10040481197/job/27746614164?pr=18)

@barmac barmac force-pushed the support-eslint-9 branch from 7bdeb30 to 4cf9084 Compare July 22, 2024 12:08
Versions 14 and 16 are out of support.
@barmac barmac marked this pull request as ready for review July 22, 2024 12:13
@barmac barmac requested review from a team, philippfromme, marstamm and nikku and removed request for a team July 22, 2024 12:13
@barmac
Copy link
Member Author

barmac commented Jul 22, 2024

I considered whether Node version update is a breaking change or not. One could argue that we drop support, but we have never made any official statement on supported Node versions. It's just that we need to have a platform to test the plugin, and the outdated Node versions seem to not be available anymore. In the end, you can probably still run the plugin on the old versions, but we want to first and foremost support the current platform. So it's not a breaking change.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 🎉

@barmac barmac merged commit 82b57ca into main Jul 22, 2024
38 checks passed
@barmac barmac deleted the support-eslint-9 branch July 22, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants