netsync: don't ask for blocks from peers on the same block height #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12803849581Details
💛 - Coveralls |
When we're all caught up and we have a new peer, we'll ask for blocks from peers that we're on the same height. Since these peers don't have any blocks to send us, they don't reply and we disconnect from them as they timeout. To prevent this, we don't ask for blocks if the chain thinks we're current and do not have a peer that reports having a higher block.
kcalvinalvin
force-pushed
the
2025-01-16-dont-ask-for-blocks-from-same-height-peers
branch
from
fb9121d to
aace7a9
Compare
|
cc: @ziggie1984 for review |
yyforyongyu
reviewed
Feb 19, 2025
| @@ -309,6 +309,11 @@ func (sm *SyncManager) startSync() { | |||
| higherPeers = append(higherPeers, peer) | |||
| } | |||
|
|
|||
| if sm.chain.IsCurrent() && len(higherPeers) == 0 { | |||
There was a problem hiding this comment.
Does it matter if we are current or not? I think as long as we have no higherPeers there's no need to sync? As these peers don't have any blocks to send us, they don't reply and we disconnect from them as they timeout.
There was a problem hiding this comment.
It doesn't matter but if the node is getting eclipse attacked, then it may be that it's not current and it doesn't have any higher peers. Thought it might be good to differentiate because of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're all caught up and we have a new peer, we'll ask for blocks from peers that we're on the same height. Since these peers don't have any blocks to send us, they don't reply and we disconnect from them as they timeout.
To prevent this, we don't ask for blocks if the chain thinks we're current and do not have a peer that reports having a higher block.