Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [issue: #6487] Rescheduling bookings should be an option #19933

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: [issue: #6487] Rescheduling bookings should be an option #19933

wants to merge 1 commit into from
+52 −15

Conversation

rohitbhure65
Copy link

@rohitbhure65 rohitbhure65 commented Mar 11, 2025 •
edited
Loading

Fixes #6487
/claim #6487

@rohitbhure65 rohitbhure65 requested a review from a team as a code owner March 11, 2025 01:49
@vercel Vercel
Copy link

vercel bot commented Mar 11, 2025

@rohitbhure65 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added this to the v5.1 milestone Mar 11, 2025
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 11, 2025
@graphite-app graphite-app bot requested a review from a team March 11, 2025 01:50
@algora-pbc algora-pbc bot mentioned this pull request Mar 11, 2025
Open
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 11, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/11/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add reschedule and cancel options with time notice constraint". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Add reschedule and cancel options with time notice constraint". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking Medium priority Created by Linear-GitHub Sync 💎 Bounty A bounty on Algora.io 🙋🏻‍♂️help wanted Help from the community is appreciated labels Mar 11, 2025
@dosubot dosubot bot added the ✨ feature New feature or request label Mar 11, 2025
@rohitbhure65 rohitbhure65 changed the title Add reschedule and cancel options with time notice constraint fix: Rescheduling bookings should be an option Mar 11, 2025
@rohitbhure65 rohitbhure65 changed the title fix: Rescheduling bookings should be an option fix: [issue: #6487] Rescheduling bookings should be an option Mar 11, 2025
retrogtx
retrogtx requested changes Mar 11, 2025
View reviewed changes
packages/features/bookings/lib/handleCancelBooking.ts
@@ -207,6 +207,18 @@ async function handler(req: CustomRequest) {
}
}

// Check if attendeeCanCancel is false or if the cancellation is within the minimum notice period
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, tests are failing probably in this file

and also we will need loom videos / explanation in the PR for this one

@Udit-takkar Udit-takkar marked this pull request as draft March 13, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrogtx retrogtx retrogtx requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync ✨ feature New feature or request 🙋🏻‍♂️help wanted Help from the community is appreciated Medium priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
v5.1
Development

Successfully merging this pull request may close these issues.

[CAL-890] Rescheduling bookings should be an option
3 participants
@rohitbhure65 @CLAassistant @retrogtx