Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom Fields OR Add-Ons with a fee associated #19997

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

asadath1395
Copy link
Contributor

@asadath1395 asadath1395 commented Mar 12, 2025

What does this PR do?

Custom Fields OR Add-Ons with a fee associated

/claim 7075

Visual Demo (For contributors especially)

Video Demo (if applicable):

https://www.loom.com/share/c4fb241826874cc894837e85534cfd7d?sid=389aae54-dc26-428d-a902-6f4ae72bc25e

Right now pricing is supported for Number, Select, MultiSelect, Checkbox, Checkbox group and Radio group input type

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Check the Video Demo

@asadath1395 asadath1395 requested a review from a team as a code owner March 12, 2025 08:26
Copy link

vercel bot commented Mar 12, 2025

@asadath1395 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team March 12, 2025 08:26
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 12, 2025
@github-actions github-actions bot added event-types area: event types, event-types linear Sync Github Issue from community members to Linear.app Low priority Created by Linear-GitHub Sync ✨ feature New feature or request 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup 💎 Bounty A bounty on Algora.io labels Mar 12, 2025
@dosubot dosubot bot added this to the v5.1 milestone Mar 12, 2025
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Mar 12, 2025
...field,
label,
...(fieldsThatSupportLabelAsSafeHtml.includes(field.type) && field.labelAsSafeHtml
? { labelAsSafeHtml: markdownToSafeHTML(label) }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have avoided markdownToSafeHTML as it says its an expensive function, but had to re-call it just to append the price

Copy link

graphite-app bot commented Mar 12, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/12/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/12/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey some type checks are failing, good pr nonetheless

@asadath1395 asadath1395 requested a review from a team as a code owner March 13, 2025 06:48
@asadath1395
Copy link
Contributor Author

hey some type checks are failing, good pr nonetheless

@retrogtx Types should be fixed now

@asadath1395 asadath1395 requested a review from retrogtx March 13, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🙋 Bounty claim 💎 Bounty A bounty on Algora.io community Created by Linear-GitHub Sync event-types area: event types, event-types ✨ feature New feature or request linear Sync Github Issue from community members to Linear.app Low priority Created by Linear-GitHub Sync 🎨 needs design Before engineering kick-off, a designer needs to submit a mockup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3967] Custom Fields OR Add-Ons with a fee associated
3 participants