-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom Fields OR Add-Ons with a fee associated #19997
base: main
Are you sure you want to change the base?
Conversation
@asadath1395 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
...field, | ||
label, | ||
...(fieldsThatSupportLabelAsSafeHtml.includes(field.type) && field.labelAsSafeHtml | ||
? { labelAsSafeHtml: markdownToSafeHTML(label) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have avoided markdownToSafeHTML
as it says its an expensive function, but had to re-call it just to append the price
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/12/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (03/12/25)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey some type checks are failing, good pr nonetheless
@retrogtx Types should be fixed now |
What does this PR do?
Custom Fields OR Add-Ons with a fee associated
/claim 7075
Visual Demo (For contributors especially)
Video Demo (if applicable):
https://www.loom.com/share/c4fb241826874cc894837e85534cfd7d?sid=389aae54-dc26-428d-a902-6f4ae72bc25e
Right now pricing is supported for Number, Select, MultiSelect, Checkbox, Checkbox group and Radio group input type
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Check the Video Demo