Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[radio] keyboard navigation not fired when using react-aria-components #1605

Closed
csantos-nydig opened this issue Nov 12, 2024 · 1 comment · Fixed by #1737
Closed

[radio] keyboard navigation not fired when using react-aria-components #1605

csantos-nydig opened this issue Nov 12, 2024 · 1 comment · Fixed by #1737
Assignees
@capricorn86
Labels
bug Something isn't working

Comments

@csantos-nydig
Copy link

Describe the bug

when using RadioGroup from react-aria-components and trying to navigate using keyboard (ArrowDown) the selection does not change.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/stackblitz-starters-erttrv?file=package.json,jsdom.spec.tsx,happy-dom.spec.tsx
  2. Run npm run test
  3. Notice it fails for HAPPY-DOM, but works for JSDOM

Expected behavior
I'd expect it to work in HAPPY-DOM

Additional context
I don't think this is an error in react-aria-components per se, because their components work fine in JSDOM; but my guess is that they are using some APIs that are not yet supported by HAPPY-DOM

I'm cross-linking both issues, so hopefully we can collaborate and see what needs to be done and where 🙏 adobe/react-spectrum#7358
@csantos-nydig csantos-nydig added the bug Something isn't working label Nov 12, 2024
@csantos-nydig csantos-nydig mentioned this issue Nov 12, 2024
Open
@capricorn86 capricorn86 self-assigned this Feb 23, 2025
capricorn86 added a commit that referenced this issue Feb 23, 2025
@capricorn86
fix: [#1605] Fixes issue when using filtering in TreeWalker, which ca…
c04db6a 
…used it not to work according to spec
@capricorn86 capricorn86 linked a pull request Feb 23, 2025 that will close this issue
fix: [#1605] Fixes issue related to the use of filtering in TreeWalker, which caused it not to work according to spec #1737
Merged
capricorn86 added a commit that referenced this issue Feb 23, 2025
@capricorn86
fix: [#1605] Fixes issue when using filtering in TreeWalker, which ca…
715e8eb 
…used it not to work according to spec
capricorn86 added a commit that referenced this issue Feb 23, 2025
@capricorn86
fix: [#1605] Fixes issue related to the use of filtering in TreeWalke…
6c5e0f9 
…r, which caused it not to work according to spec (#1737)

* fix: [#1605] Fixes issue when using filtering in TreeWalker, which caused it not to work according to spec

* fix: [#1605] Fixes issue when using filtering in TreeWalker, which caused it not to work according to spec
@capricorn86
Copy link
Owner

Thank you for reporting @csantos-nydig! 🙂

This has been fixed now in v17.1.4.

capricorn86 added a commit that referenced this issue Feb 24, 2025
@capricorn86
fix: [#1614] Fixes issue where change event wasn't triggered for an i…
73a3672 
…nput inside of a label (#1743)

* fix: [#1605] Fixes issue when using filtering in TreeWalker, which caused it not to work according to spec

* fix: [#1605] Fixes issue when using filtering in TreeWalker, which caused it not to work according to spec

* chore: [#1614] Fixes issue where input change event wasnt triggered when clicking on an element inside of a label

* chore: [#1614] Fixes issue where input change event wasnt triggered when clicking on an element inside of a label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capricorn86 capricorn86

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@capricorn86 @csantos-nydig