Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1718] AbortSignal reason can have any type and the value should be used without being wrapped when rejecting a fetch #1729

Merged

Conversation

btea
Copy link
Contributor

@btea btea commented Feb 17, 2025

close #1718

@btea btea requested a review from capricorn86 as a code owner February 17, 2025 09:15
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @btea! ⭐

I have made additional fixes according to spec. I have also added some more unit tests.

@capricorn86 capricorn86 changed the title fix: [#1718] Fetch aborted due to timeout signal error message name incorrect fix: [#1718] AbortSignal reason can have any type and the value should be used without being wrapped when rejecting a fetch Feb 21, 2025
@capricorn86 capricorn86 merged commit 6ced6d8 into capricorn86:master Feb 21, 2025
3 checks passed
@btea btea deleted the fix/fetch-abort-signal-timeout-error-name branch February 22, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants