fix windows #4
Merged
fix windows #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't build the broken examples by default (can still try to build/run them explicitly) 2. Properly detect the right directory separator (for windows use '\') when converting example path to name 3. Use the '\' path separator on Windows 4. Handle the WM_DESTROY window message so the process exits when the user closes the app
|
Thanks you! I'm currently working on testing so cases where errors like that (at least compilation errors) won't happen anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'\') when converting example path to name'\'path separator on WindowsWith this I can now build/run 4 of the examples on my Windows 10 machine,
calculator,colors,demoandgraph.