Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on reload with Pipeline's _has_message at acknowledge #1438

Closed
ghost opened this issue Aug 23, 2019 · 1 comment
Closed

Errors on reload with Pipeline's _has_message at acknowledge #1438

ghost opened this issue Aug 23, 2019 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Milestone

Comments

@ghost
Copy link

ghost commented Aug 23, 2019

The introduction of the Pipeline's _has_message safety flag in 100d342 discloses an error at reload:

2019-08-23 02:17:12,380 - maxmind-geoip-expert - INFO - Handling SIGHUP, initializing again now.
2019-08-23 02:17:12,381 - maxmind-geoip-expert - INFO - GeoIPExpertBot initialized with id maxmind-geoip-expert and intelmq 2.1.0.alpha.1 and python 3.4.2 (default, Aug 17 2019, 10:19:24) as process 27276.
2019-08-23 02:17:12,382 - maxmind-geoip-expert - INFO - Bot is starting.
2019-08-23 02:17:12,419 - maxmind-geoip-expert - INFO - Bot initialization completed.
2019-08-23 02:17:12,420 - maxmind-geoip-expert - INFO - Loading source pipeline and queue 'maxmind-geoip-expert-queue'.
2019-08-23 02:17:12,426 - maxmind-geoip-expert - INFO - Acknowledge called.
2019-08-23 02:17:12,427 - maxmind-geoip-expert - ERROR - Pipeline failed.
Traceback (most recent call last):
  File "/home/aaron/intelmq/intelmq/lib/bot.py", line 269, in start
    self.process()
  File "/home/aaron/intelmq/intelmq/bots/experts/maxmind_geoip/expert.py", line 72, in process
    self.acknowledge_message()
  File "/home/aaron/intelmq/intelmq/lib/bot.py", line 616, in acknowledge_message
    self.__source_pipeline.acknowledge()
  File "/home/aaron/intelmq/intelmq/lib/pipeline.py", line 132, in acknowledge
    raise exceptions.PipelineError("No message to acknowledge.")
intelmq.lib.exceptions.PipelineError: pipeline failed - 'No message to acknowledge.'

The INFO - Acknowledge called. message was added for debugging purposes. So the pipeline is reset at reload, but the bot still knows of the previously processed message.

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: core labels Aug 23, 2019
@ghost ghost added this to the 2.1.0 milestone Aug 23, 2019
@ghost
Copy link
Author

ghost commented Aug 23, 2019

Probably cause:

intelmq/intelmq/lib/bot.py

Lines 572 to 573 in 4ea27b9

# handle a sighup which happened during blocking read
self.__handle_sighup()
in receive_message

ghost pushed a commit that referenced this issue Aug 23, 2019
@ghost ghost self-assigned this Aug 26, 2019
@ghost ghost closed this as completed in 0e9dc69 Aug 26, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Development

No branches or pull requests

0 participants