Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot debugger: fails on message sending with permissive paths #1453

Closed
grodriguezl opened this issue Sep 17, 2019 · 2 comments
Closed

bot debugger: fails on message sending with permissive paths #1453

grodriguezl opened this issue Sep 17, 2019 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Milestone

Comments

@grodriguezl
Copy link
Contributor

grodriguezl commented Sep 17, 2019

Filter bot with paths fails. It seems that it fails for every queue in destination_queues.

It happens on intelmq 2.0.1 installed using pip and CentOS native package.

Error:

intelmqctl run Filter-Expert process --show-sent --msg ' { "source.ip": "93.184.216.34", "source.geolocation.cc": "UU", "time.observation": "2015-01-01T00:00:00+00:00" }'


Traceback (most recent call last):
  File "/bin/intelmqctl", line 11, in <module>
    load_entry_point('intelmq==2.0.1', 'console_scripts', 'intelmqctl')()
  File "/usr/lib/python3.6/site-packages/intelmq/bin/intelmqctl.py", line 1710, in main
    return x.run()
  File "/usr/lib/python3.6/site-packages/intelmq/bin/intelmqctl.py", line 948, in run
    retval, results = args.func(**args_dict)
  File "/usr/lib/python3.6/site-packages/intelmq/bin/intelmqctl.py", line 955, in bot_run
    return self.bot_process_manager.bot_run(**kwargs), None
  File "/usr/lib/python3.6/site-packages/intelmq/bin/intelmqctl.py", line 162, in bot_run
    loglevel=loglevel)
  File "/usr/lib/python3.6/site-packages/intelmq/lib/bot_debugger.py", line 60, in __init__
    self._process(dryrun, msg, show)
  File "/usr/lib/python3.6/site-packages/intelmq/lib/bot_debugger.py", line 142, in _process
    self.instance.process()
  File "/usr/lib/python3.6/site-packages/intelmq/bots/experts/filter/expert.py", line 125, in process
    path_permissive=True)
TypeError: <lambda>() got an unexpected keyword argument 'path_permissive'

Example of pipeline.conf:

"Filter-Expert": {
        "source-queue": "Filter-Expert-queue",
        "destination-queues": {
            "_default": "cymru-whois-expert-queue",
            "_on_error": "url2fqdn-expert-queue",
            "filter_match": "url2fqdn-expert-queue",
            "action_other": "url2fqdn-expert-queue"
        }
    },

Example2

"Filter-Expert": {
        "source-queue": "Filter-Expert-queue",
        "destination-queues": [
            "url2fqdn-expert-queue"
        ]
    },

@grodriguezl grodriguezl changed the title Named destination queues error Filter bot - Named destination queues error Sep 17, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

That only affects the bot debugger. I will find a generic way to mock that method

cc @e3rd

@ghost ghost changed the title Filter bot - Named destination queues error bot debugger: fails on message sending with permissive paths Sep 18, 2019
@ghost ghost self-assigned this Sep 18, 2019
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: intelmqctl labels Sep 18, 2019
@ghost ghost added this to the 2.0.2 milestone Sep 18, 2019
e3rd added a commit that referenced this issue Sep 18, 2019
@e3rd
Copy link
Member

e3rd commented Sep 18, 2019

this PR might do :)

@ghost ghost closed this as completed in 1ed633c Sep 20, 2019
@ghost ghost modified the milestones: 2.1.1, 2.0.2 Oct 25, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants