Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub API collector: support for personal access token #1549

Closed
ghost opened this issue Jun 22, 2020 · 0 comments · Fixed by #2145
Closed

GitHub API collector: support for personal access token #1549

ghost opened this issue Jun 22, 2020 · 0 comments · Fixed by #2145
Assignees
@waldbauer-certat
Labels
component: bots feature Indicates new feature requests or new features

Comments

@ghost
Copy link

ghost commented Jun 22, 2020

Currently the GitHub API Collector uses username and password for a HTTP Basic Auth authentication. This does not work for Accounts with 2FA enabled and is deprecated too: https://developer.github.com/changes/2020-02-14-deprecating-password-auth/

Using personal access tokens is the way to go.
@ghost ghost added feature Indicates new feature requests or new features component: bots labels Jun 22, 2020
@ghost ghost added this to the 2.3.0 milestone Jun 22, 2020
@ghost ghost removed this from the 2.3.0 milestone Feb 4, 2021
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
a2e30d7 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
@waldbauer-certat waldbauer-certat mentioned this issue Feb 1, 2022
Merged
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
345c640 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
bb3e000 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
ecad38a 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
0318e42 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 2, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
b30d3c2 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 2, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
65bdb83 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 2, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
9dc1cf8 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 2, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
7383af1 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 2, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
5fc604d 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 2, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
83ee978 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
@waldbauer-certat waldbauer-certat self-assigned this Feb 4, 2022
waldbauer-certat added a commit that referenced this issue Jul 6, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
03d67b0 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Jul 6, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
83027f2 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Jul 7, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
ed819e9 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Jul 7, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
2a4beaf 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Jul 7, 2022
@waldbauer-certat
ENH: Added personal access token support to GitHub Collector
7b2dc7a 
As github basic authentication has been marked as deprecated by
GitHub, we now implemented the Personal Access Token authentication
method.

Fixes #1549

Signed-off-by: Sebastian Waldbauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waldbauer-certat waldbauer-certat

Labels
component: bots feature Indicates new feature requests or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Added personal access token support to GitHub Collector certtools/intelmq
1 participant
@waldbauer-certat