Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use file locks for file collector and output bots #1631

Open
ghost opened this issue Oct 22, 2020 · 0 comments
Open

Use file locks for file collector and output bots #1631

ghost opened this issue Oct 22, 2020 · 0 comments
Labels
component: bots feature Indicates new feature requests or new features

Comments

@ghost
Copy link

ghost commented Oct 22, 2020

To prevent accidental data loss and duplicate data, we can add file locking capability (by default with opt-out) to file file collector and file output bot.
The bot's only read (collector) or write to (output) the file if they get an exclusive file lock.
@ghost ghost added feature Indicates new feature requests or new features component: bots labels Oct 22, 2020
@sebix sebix mentioned this issue Nov 30, 2021
Closed
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
1f40b23 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <[email protected]>
@waldbauer-certat waldbauer-certat mentioned this issue Feb 1, 2022
Merged
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
74ecf6e 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
ecb99ac 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat added a commit that referenced this issue Feb 1, 2022
@waldbauer-certat
FIX: Possible race condition in file collector
7a518ea 
Locking the file with python fcntl to aquire a file lock,
it may not support windows installations :/

Fixes #2128
Fixes #1631

Signed-off-by: Sebastian Waldbauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: bots feature Indicates new feature requests or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants