Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot database update scripts: Be quiet by default in cron scripts #2016

Closed
ghost opened this issue Jul 6, 2021 · 1 comment · Fixed by #2033
Closed

Bot database update scripts: Be quiet by default in cron scripts #2016

ghost opened this issue Jul 6, 2021 · 1 comment · Fixed by #2033
Labels
component: bots feature Indicates new feature requests or new features needs: discussion
Milestone
3.0.1

Comments

@ghost
Copy link

ghost commented Jul 6, 2021

Currently, the bot database update scripts print this on every call if nothing is done:

Database update skipped. No bots of type intelmq.bots.experts.asn_lookup.expert present in runtime.conf.

I think a good default would be to be quiet by default on the cron runs, e.g. by setting a --quiet flag. If the user wants to have verbose information, it can always be turned on.

Or: honour the logging level as defined for the bot. With the configuration overhaul, this should now be easier to do on the code-side.
@ghost ghost added feature Indicates new feature requests or new features component: bots labels Jul 6, 2021
@ghost ghost added this to the 3.0.1 milestone Aug 5, 2021
@ghost ghost added the needs: discussion label Aug 5, 2021
@ghost ghost self-assigned this Aug 10, 2021
ghost pushed a commit that referenced this issue Aug 11, 2021
Make update scripts less verbose by default
ead8ceb 
This introduces a --verbose flag to the experts which use update
functions. The default behaviour now is to *not* print any messages,
which makes the update function less noisy when used with cron.

Fixes #2016
@ghost ghost mentioned this issue Aug 11, 2021
Merged
@ghost ghost closed this as completed in #2033 Aug 11, 2021
ghost pushed a commit that referenced this issue Aug 11, 2021
Make update scripts less verbose by default
8b2d9d8 
This introduces a --verbose flag to the experts which use update
functions. The default behaviour now is to *not* print any messages,
which makes the update function less noisy when used with cron.

Fixes #2016
ghost pushed a commit that referenced this issue Aug 11, 2021
Make update scripts less verbose by default
e885668 
This introduces a --verbose flag to the experts which use update
functions. The default behaviour now is to *not* print any messages,
which makes the update function less noisy when used with cron.

Fixes #2016
@ghost
Copy link
Author

ghost commented Sep 9, 2021

in the domain suffix expert, one line was missing (the Database update skipped...).

ghost pushed a commit that referenced this issue Sep 9, 2021
bug: domain suffix expert: skipped update message
93808c3 
Only print skipped database update message if verbose mode is active

fixes #2016
@ghost ghost mentioned this issue Sep 9, 2021
Merged
ghost pushed a commit that referenced this issue Sep 9, 2021
bug: domain suffix expert: skipped update message
d396543 
Only print skipped database update message if verbose mode is active

fixes #2016
ghost pushed a commit that referenced this issue Sep 9, 2021
bug: domain suffix expert: skipped update message
c5fdf93 
Only print skipped database update message if verbose mode is active

fixes #2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: bots feature Indicates new feature requests or new features needs: discussion
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

Make update script less verbose by default certtools/intelmq
0 participants