Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowserver feeds: Microsoft Sinkhole report split #2019

Closed
ghost opened this issue Jul 16, 2021 · 0 comments · Fixed by #2036
Closed

Shadowserver feeds: Microsoft Sinkhole report split #2019

ghost opened this issue Jul 16, 2021 · 0 comments · Fixed by #2036
Milestone

Comments

@ghost
Copy link

ghost commented Jul 16, 2021

Looking at some more new feeds, there were two more feed changes made on June 8 which replace the existing Microsoft Sinkhole report:

2021-06-08 UPDATE:

LEGACY: Microsoft Sinkhole Report has been replaced by two reports: Microsoft Sinkhole Events Report and Microsoft Sinkhole HTTP Events Report.

https://www.shadowserver.org/what-we-do/network-reporting/microsoft-sinkhole-events-report/
https://www.shadowserver.org/what-we-do/network-reporting/microsoft-sinkhole-http-events-report/

Looking at the report and the mapping at https://github.com/certtools/intelmq/blob/develop/intelmq/bots/parsers/shadowserver/_config.py#L2856, the formats seem to match the other sinkhole report fields, so we could possibly just add new mappings for these reports like:

    ('Microsoft-Sinkhole-Events', 'event4_sinkhole', event46_sinkhole),
    ('Microsoft-Sinkhole-Events-HTTP IPv4', 'event4_microsoft_sinkhole_http', event46_sinkhole_http),

If anyone else is also looking at this, would be interested in your thoughts on this approach.

Originally posted by @chorsley in #1964 (comment)

@ghost ghost added the component: bots label Jul 16, 2021
@ghost ghost added this to the 3.0.1 milestone Jul 16, 2021
@ghost ghost self-assigned this Aug 12, 2021
@ghost ghost mentioned this issue Aug 12, 2021
ghost pushed a commit that referenced this issue Aug 16, 2021
Microsoft Sinkhole Report has been replaced by two reports: Microsoft
Sinkhole Events Report and Microsoft Sinkhole HTTP Events Report.

Added the config, added the tests, csv files, license files and
mentioned the changes in the CHANGELOG.

Fixes: #2019
@ghost ghost closed this as completed in #2036 Aug 16, 2021
ghost pushed a commit that referenced this issue Aug 16, 2021
Microsoft Sinkhole Report has been replaced by two reports: Microsoft
Sinkhole Events Report and Microsoft Sinkhole HTTP Events Report.

Added the config, added the tests, csv files, license files and
mentioned the changes in the CHANGELOG.

Fixes: #2019
ghost pushed a commit that referenced this issue Aug 16, 2021
Microsoft Sinkhole Report has been replaced by two reports: Microsoft
Sinkhole Events Report and Microsoft Sinkhole HTTP Events Report.

Added the config, added the tests, csv files, license files and
mentioned the changes in the CHANGELOG.

Fixes: #2019
waldbauer-certat pushed a commit that referenced this issue Aug 16, 2021
Microsoft Sinkhole Report has been replaced by two reports: Microsoft
Sinkhole Events Report and Microsoft Sinkhole HTTP Events Report.

Added the config, added the tests, csv files, license files and
mentioned the changes in the CHANGELOG.

Fixes: #2019
waldbauer-certat pushed a commit that referenced this issue Sep 9, 2021
Microsoft Sinkhole Report has been replaced by two reports: Microsoft
Sinkhole Events Report and Microsoft Sinkhole HTTP Events Report.

Added the config, added the tests, csv files, license files and
mentioned the changes in the CHANGELOG.

Fixes: #2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants