Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctl tests require an installed IntelMQ instance #2300

Closed
wagner-intevation opened this issue Jan 24, 2023 · 2 comments · Fixed by #2301
Closed

ctl tests require an installed IntelMQ instance #2300

wagner-intevation opened this issue Jan 24, 2023 · 2 comments · Fixed by #2301
Assignees
@wagner-intevation
Labels
bug Indicates an unexpected problem or unintended behavior component: tests
Milestone
3.1.0

Comments

@wagner-intevation
Copy link
Contributor

wagner-intevation commented Jan 24, 2023 •
edited
Loading

@kamil-certat test_check_pass_with_default_runtime and test_check_passed_with_default_harmonization_and_empty_runtime assume a local installation of IntelMQ, including a state file and the bot executables in $PATH. Is that intentional?
@kamil-certat
Copy link
Contributor

Not entirely, but I need to verify the behavior, and ensure I've tested it properly.

The assumption was that we have the working and importable IntelMQ package, installed with setup.py or similar (= normal pre-step for unittests). This should be enough to install all entry points (and all bots, all in entry points as per setup.py). The state file is, however, missed by me, but please note: the missing state file shouldn't break tests - it doesn't change the return value.

@sebix sebix added this to the 3.1.0 milestone Jan 26, 2023
@sebix sebix added the bug Indicates an unexpected problem or unintended behavior label Jan 26, 2023
@wagner-intevation
Copy link
Contributor Author

Working on a fix/workaround

wagner-intevation added a commit to wagner-intevation/intelmq that referenced this issue Jan 26, 2023
@wagner-intevation
TST: bin/ctl.check: Skip executables check in tests
cb61008 
in test environments, the executables don't exist necessarily
add a parameter to check() to allow skipping these tests

fixes certtools#2300
@wagner-intevation wagner-intevation mentioned this issue Jan 26, 2023
Merged
@wagner-intevation wagner-intevation mentioned this issue May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wagner-intevation wagner-intevation

Labels
bug Indicates an unexpected problem or unintended behavior component: tests
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

TST: bin/ctl.check: Skip executables check in tests wagner-intevation/intelmq
3 participants
@sebix @wagner-intevation @kamil-certat