Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush statistics before sleeping #2336

Closed
kamil-certat opened this issue Mar 15, 2023 · 0 comments · Fixed by #2337
Closed

Flush statistics before sleeping #2336

kamil-certat opened this issue Mar 15, 2023 · 0 comments · Fixed by #2337
Assignees
@kamil-certat
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Milestone
3.1.1

Comments

@kamil-certat
Copy link
Contributor

Applying rate limiting (__sleep()) on bots is done before flushing statistics. If rate limiting is high, this causes significant delay in statistic data.
kamil-certat added a commit to kamil-certat/intelmq that referenced this issue Mar 15, 2023
@kamil-certat
FIX: Flush statistics before rate limiting bot
7f06d98 
Previously, statistics weren't flushed before applying rate limiting,
even if sleeping time was longer than statistics delay. This caused
significant delay in statistics. Now, statistics are flushed before
sleeping, if expected delay is longer than flushing delay.

Fixes certtools#2336
@kamil-certat kamil-certat mentioned this issue Mar 15, 2023
Merged
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: core labels Mar 16, 2023
@sebix sebix added this to the 3.1.1 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamil-certat kamil-certat

Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Milestone
3.1.1
Development

Successfully merging a pull request may close this issue.

FIX: Flush statistics before rate limiting bot kamil-certat/intelmq
2 participants
@sebix @kamil-certat