Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IntelMQ plugable #972

Closed
dmth opened this issue May 12, 2017 · 2 comments · Fixed by #1751
Closed

Make IntelMQ plugable #972

dmth opened this issue May 12, 2017 · 2 comments · Fixed by #1751
Labels
architecture feature Indicates new feature requests or new features
Milestone

Comments

@dmth
Copy link
Contributor

dmth commented May 12, 2017

We've already discussed this some times in the dev - calls but I couldn't find an issue which states this demand.

From my point of view IntelMQ will get better when using a plug-able structure, allowing to add own plug-ins with more ease.

I try to start anew with a collection of already existing Issues and code which are / is covering this topic.

I understood that we've already reached some kind of consensus that this structure is something we want to pursue. So let's just start to discuss and collect what's required to achieve this goal.

Maybe we can start by collecting some, even fictional, requirements:

  • As an operator of an IntelMQ instance, I'd like to add my own code for bots which processes internal information without the need of manually editing the bots file.
  • As an admin I want to install IntelMQ without the need of installing libraries which are not required for my use-case. Code for bots that is not necessary should not exist on my systems.

please continue...

@ghost ghost added this to the v1.1 Feature release milestone May 15, 2017
@ghost ghost added architecture feature Indicates new feature requests or new features labels May 15, 2017
@ghost ghost modified the milestones: 1.1.0, 2.0.0 Jun 28, 2018
@ghost ghost modified the milestones: 2.0.0, 2.1.0 Apr 10, 2019
@ghost ghost modified the milestones: 2.1.0, 2.2.0 Oct 25, 2019
@ghost ghost modified the milestones: 2.2.0, 3.0.0 Jun 17, 2020
@gethvi
Copy link
Contributor

gethvi commented Jul 13, 2020

As an admin I want to install IntelMQ without the need of installing libraries which are not required for my use-case. Code for bots that is not necessary should not exist on my systems.

I have a suggestion for this. We could use setuptools with extras for installing bots with specific dependencies like this for example:

pip3 install intelmq[maxmind_geoip]

More:
https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies

@wagner-certat Do you think this would be sensible approach?

@ghost
Copy link

ghost commented Jul 13, 2020

I thought about this approach for the contrib-tools and for the optional dependencies, e.g.

  • intelmq[contrib]: installs all contrib tools
  • intelmq: like current
  • intelmq[all]: Installs all dependencies of bots

If you also want to do that per bot, we can have a minimal core installation (no bots, just libs) + one package per bot. But keep in mind, that this has a few dependencies on other issues solved first or together and the work needed for adding new bots should - all in all - be about the same as currently.

@ghost ghost closed this as completed in #1751 Mar 15, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture feature Indicates new feature requests or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants