fix type mapping for n6 parser #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
bug
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## maintenance #1127 +/- ##
===============================================
+ Coverage 75.31% 75.31% +<.01%
===============================================
Files 217 217
Lines 9239 9240 +1
Branches 1246 1246
===============================================
+ Hits 6958 6959 +1
Misses 1996 1996
Partials 285 285
|
aaronkaplan
approved these changes
Dec 4, 2017
| @@ -59,8 +59,8 @@ | |||
| "type": "malware", "identifier": "malware"} | |||
| mapping['vulnerable'] = {"taxonomy": "Vulnerable", | |||
| "type": "other", "identifier": "vulnerable"} | |||
| mapping['other'] = {"taxonomy": "Vulnerable", | |||
| "type": "unknown", "identifier": "unknown"} | |||
| mapping['other'] = {"taxonomy": "Other", | |||
| "type": "proxy", "identifier": "open proxy"} | ||
| mapping['sandbox-url'] = {"taxonomy": "ignore", | ||
| "type": "ignore", "identifier": "ignore me"} | ||
| mapping['proxy'] = {"taxonomy": "Other", |
There was a problem hiding this comment.
might be replaced in the future by the taxonomy "accessible". But that's the future....
| "type": "ignore", "identifier": "ignore me"} | ||
| mapping['proxy'] = {"taxonomy": "Other", | ||
| "type": "proxy", "identifier": "openproxy"} | ||
| mapping['sandbox-url'] = {"taxonomy": "malicious code", |
|
@wagner-certat I think we can merge this. |
in certtools/inetlmq#738
|
Thanks for the review @aaronkaplan I additionally added details to the NEWS file including an SQL statement. |
added 2 commits
December 6, 2017 10:28
including allowed values
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #738
mappings for idea are confirmed by @pharook