Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: ctl: proper exit codes #1143

Merged
2 commits merged into from
Jan 15, 2018
Merged

BUG: ctl: proper exit codes #1143

2 commits merged into from
Jan 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2017

intelmqctl now exits with exit codes > 0 when errors happened or the operation was not successful. Also, the status operation exits with 1, if bots are stopped, but enabled. (fixes #977)

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: intelmqctl labels Dec 20, 2017
@ghost ghost added this to the 1.0.3 milestone Dec 20, 2017
@codecov-io
Copy link

codecov-io commented Dec 20, 2017

Codecov Report

Merging #1143 into maintenance will decrease coverage by 0.2%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           maintenance    #1143      +/-   ##
===============================================
- Coverage        75.28%   75.08%   -0.21%     
===============================================
  Files              217      217              
  Lines             9246     9271      +25     
  Branches          1248     1255       +7     
===============================================
  Hits              6961     6961              
- Misses            1999     2024      +25     
  Partials           286      286
Impacted Files Coverage Δ
intelmq/bin/intelmqctl.py 11.11% <0%> (-0.46%) ⬇️

@ghost ghost added the usability label Dec 20, 2017
@ghost
Copy link
Author

ghost commented Jan 15, 2018

Got no feedback, so probably ok

@ghost ghost merged commit 8a55970 into maintenance Jan 15, 2018
@ghost ghost deleted the fix-977 branch January 17, 2018 14:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant