Extra log line during dumping message process #1161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only "small" reason for the additional line is just to help users on the same problem as I had which is:
A parser bot is processing thousands of lines and in the middle of the process, parser found one line with an error and automatically wrote a log message about it but continued. In the end, after all thousand lines processed, the log file is full of messages saying
INFO - Processed 500 messages since last logging.
and in the end has an additional log message sayingINFO - Dumping message from pipeline to dump file.
.In my perspective, before the log line
INFO - Dumping message from pipeline to dump file.
, bot should write another log line mentioning the issue with the specific message that is about to dump in order to alert the user that need to check all log file looking for that error. Otherwise the user may have difficulties to understand where the dump message came from after all processed lines.