Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves travis setup. #1169

Merged
1 commit merged into from
Jan 23, 2018

Conversation

bernhardreiter
Copy link
Contributor

  • Puts popd on a line of its own, otherwise its return value will
    override the exit code of the dpkg-buildpackage command, causing a
    successful build, even with it failed.

 * Puts popd on a line of its own, otherwise its return value will
   override the exit code of the dpkg-buildpackage command, causing a
   successful build, even with it failed.
@ghost ghost self-assigned this Jan 22, 2018
@ghost ghost changed the base branch from master to maintenance January 22, 2018 16:09
@ghost
Copy link

ghost commented Jan 22, 2018

I noticed this too a few days ago.

We probably need to deactivate the build requirement check.

@ghost
Copy link

ghost commented Jan 22, 2018

Changed the branch to maintenance (next upcoming version). The failing unit test is fixed there.

@bernhardreiter
Copy link
Contributor Author

We probably need to deactivate the build requirement check.

I'm not sure what you mean here.

(If debian packages are to be build by the CI, of course success should be checked. )

@ghost
Copy link

ghost commented Jan 22, 2018

Trusty (used by travis) has all build dependencies except for redis and termstyle. (See also #536)

So we can't fulfill all the requirements without adding my own repositories.

(If debian packages are to be build by the CI, of course success should be checked. )

But they are not distributed, so we only check for "syntactic" correctness with this build.

Will merge and push additional fixes tomorrow.

@ghost ghost merged commit 8204204 into certtools:maintenance Jan 23, 2018
@ghost
Copy link

ghost commented Jan 23, 2018

We can't run the debhelpers' tests because of travis-ci/travis-ci#2231 (see log https://travis-ci.org/wagner-certat/intelmq/jobs/332231121#L779 )

@bernhardreiter bernhardreiter deleted the dev-travis-fix-dpkg-status-code branch April 17, 2019 10:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant