Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Shadowserver Accessible-Hadoop reports #1231

Merged
2 commits merged into from
Apr 20, 2018
Merged

Added support for Shadowserver Accessible-Hadoop reports #1231

2 commits merged into from
Apr 20, 2018

Conversation

antoinet
Copy link
Contributor

Added mapping of Shadowserver accessible hadoop csv to intelmq in config.py according to https://www.shadowserver.org/wiki/pmwiki.php/Services/Accessible-Hadoop

@codecov-io
Copy link

Codecov Report

Merging #1231 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1231      +/-   ##
===========================================
+ Coverage    75.07%   75.12%   +0.04%     
===========================================
  Files          256      257       +1     
  Lines        11967    11990      +23     
  Branches      1588     1589       +1     
===========================================
+ Hits          8984     9007      +23     
  Misses        2636     2636              
  Partials       347      347
Impacted Files Coverage Δ
...ots/parsers/shadowserver/test_accessible_hadoop.py 100% <100%> (ø)
intelmq/bots/parsers/shadowserver/config.py 87.73% <100%> (+0.11%) ⬆️

@ghost
Copy link

ghost commented Apr 20, 2018

according to https://www.shadowserver.org/wiki/pmwiki.php/Services/Accessible-Hadoop

The documentation does not always reflect the actual data format sent, did you cross-check that?

@ghost ghost self-assigned this Apr 20, 2018
@ghost ghost added feature Indicates new feature requests or new features component: bots labels Apr 20, 2018
@ghost ghost added this to the 1.1.0 milestone Apr 20, 2018
@antoinet
Copy link
Contributor Author

Yes, I'm already running the code with live data.

@ghost
Copy link

ghost commented Apr 20, 2018

Great, thanks!

@ghost ghost merged commit 378ba58 into certtools:develop Apr 20, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bots feature Indicates new feature requests or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants