Update to publicsuffixlist version requirement #1257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If version at https://pypi.org/project/publicsuffixlist/#history, should be 0.6.1 as latest.
Codecov Report
@@ Coverage Diff @@
## develop #1257 +/- ##
========================================
Coverage 75.16% 75.16%
========================================
Files 260 260
Lines 12239 12239
Branches 1642 1642
========================================
Hits 9199 9199
Misses 2686 2686
Partials 354 354 |
|
What's the reasoning? The version 0.6.1 only changes some package metadata, I don't see why we nee to require the new version. |
|
When I attempted to |
|
Uh, that should be 0.6.0 instead of 6.0.0, right. Thanks! |
ghost
added
bug
|
I also adapted the travis configuration to catch errors like this one, so this should not happen again. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If version at https://pypi.org/project/publicsuffixlist/#history, should be 0.6.1 as latest.