bot debugger fix #1263
Closed
bot debugger fix #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collectors don't have inputs, but they can send messages. Output's don't send messages. |
Codecov Report
@@ Coverage Diff @@
## develop #1263 +/- ##
=========================================
- Coverage 75.4% 75.3% -0.1%
=========================================
Files 280 269 -11
Lines 12998 12666 -332
Branches 1753 1717 -36
=========================================
- Hits 9801 9538 -263
+ Misses 2812 2751 -61
+ Partials 385 377 -8
|
|
Thanks, I've added the check that Output's don't send messages and rebased. Note that my commit doesn't prevent Collectors to send_message but only to send_message with the |
Don't know a reason against it. The currently existing one's don't do it, but for custom ones it's possible. |
ghost
reviewed
Jul 2, 2018
intelmq/lib/bot_debugger.py
Outdated
| @@ -12,6 +12,7 @@ | |||
| * processes single message, either injected or from default pipeline (process subcommand) | |||
| * reads the message from input pipeline or send a message to output pipeline (message subcommand) | |||
| """ | |||
| import inspect | |||
There was a problem hiding this comment.
(sorry, for nothing, removing)
ghost
added
bug
ghost
self-assigned this
collector bots have no input queue, output bots have no output queue
|
Ah, okay. So this PR covers the fix that Collector bot cannot perform "get" and "pop" opererations (because collectors have no input queue) and that Output bot cannot perform send operation (because outpus have no output queue). Does this make sense to you like this? I've changed the commit message. |
ghost
closed this
ghost
pushed a commit
that referenced
this pull request
Sep 3, 2018
Maintenance release 1.0.6 1.0.6 Bugfix release (2018-08-31) \# Bots \## Collectors - `bots.collectors.rt.collector_rt`: Log ticket id for downloaded reports. \## Parsers - `bots.parsers.shadowserver`: - if required fields do not exist in data, an exception is raised, so the line will be dumped and not further processed. - fix a bug in the parsing of column `cipher_suite` in ssl poodle reports (#1288). \## Experts - Reverse DNS Expert: ignore all invalid results and use first valid one (#1264). - `intelmq/bots/experts/tor_nodes/update-tor-nodes`: Use check.torproject.org as source as internet2.us is down (#1289). \## Outputs - `bots.output.amqptopic`: - The default exchange must not be declared (#1295). - Unencodable characters are prepended by backslashes by default. Otherwise Unicode characters can't be encoded and sent (#1296). - Gracefully close AMQP connection on shutdown of bot. \# Documentation - Bots: document redis cache parameters. - Installation documentation: Ubuntu needs universe repositories. \# Packaging - Dropped support for Ubuntu 17.10, it reached its End of Life as of 2018-07-19. \# Tests - Drop tests for Python 3.3 for the mode with all requirements, as some optional dependencies do not support Python 3.3 anymore. - `lib.test`: Add parameter `compare_raw` (default: `True`) to `assertMessageEqual`, to optionally skip the comparison of the raw field. - Add tests for RT collector. - Add tests for Shadowserver Parser: - SSL Poodle Reports. - Helper functions. \# Tools - `intelmqctl list` now sorts the output of bots and queues (#1262). - `intelmqctl`: Correctly handle the corner cases with collectors and outputs for getting/sending messages in the bot debugger (#1263). - `intelmqdump`: fix ordering of dumps in a file in runtime. All operations are applied to a sorted list (#1280). \# Contrib - `cron-jobs/update-tor-nodes`: Use check.torproject.org as source as internet2.us is down (#1289).
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collector bots have no input queue and no send_message(path) keyword