Name and Provider fields cleaning #1321
Conversation
Codecov Report
@@ Coverage Diff @@
## maintenance #1321 +/- ##
===============================================
+ Coverage 75.63% 75.64% +<.01%
===============================================
Files 273 273
Lines 12868 12872 +4
Branches 1746 1748 +2
===============================================
+ Hits 9733 9737 +4
Misses 2738 2738
Partials 397 397
|
There was a problem hiding this comment.
Thanks for approaching this issue! Looks good overall.
The parameters in intelmq/bot/BOTS is not sorted anymore
Thanks also for fixing the missing/wrong parameters in feeds and bots documentation for some bots.
Could you please also fix the name of the parameter in docs/Bots.md section "Common parameters"? It's still called feed there.
| dest="runtime_file", | ||
| metavar="<filepath>", | ||
| required=False, | ||
| help='/tmp/runtime.conf') |
There was a problem hiding this comment.
Proposal:
help="write runtime configuration to the given file (e.g. '/tmp/runtime.conf') instead of stdout")
Same with the pipeline configuration
| print("Runtime configuration written to: %s" % arguments.runtime_file) | ||
| else: | ||
| print("\nRuntime configuration:\n") | ||
| print(json.dumps(runtime_config, indent=4)) |
There was a problem hiding this comment.
We also use these parameters in most places: sort_keys=True, separators=(',', ': ')
Sorting is necessary for a reproducible ordering.
|
I fixed the bin/rewrite_config_files to do the BOTS sorting (more) correctly in ad5afcb |
ghost
added
bug
ghost
self-assigned this
ghost
merged commit 
Solution for: #1314