ENH: Blueliv collector accepts arbitrary API URL #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-free Blueliv crimeserver API uses a different API URL which the original Blueliv collector was not able to receive as an input.
Codecov Report
@@ Coverage Diff @@
## develop #1336 +/- ##
===========================================
- Coverage 74.6% 74.59% -0.02%
===========================================
Files 294 294
Lines 13486 13488 +2
Branches 1827 1828 +1
===========================================
Hits 10061 10061
- Misses 3011 3013 +2
Partials 414 414
|
Set the api url to default if not given as parameter
ghost
self-assigned this
ghost
added
feature
|
Could you please describe the two APIs in the feeds documentation? Ie. That the one is free and the other one is commercial, and probably other differences. I added a commit to you branch adding docs and backwards compatibility. |
|
The documentation for Blueliv APIs is quite sparse. The official API reference uses the non-free API https://api.blueliv.com however the SDK REST API wiki uses an example of a free API https://freeapi.blueliv.com. |
|
Thanks for the additions! |
ghost
self-requested a review
ghost
approved these changes
Oct 19, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-free Blueliv crimeserver API uses a different API URL which the original Blueliv collector was not able to receive as an input.