Dataplane parser refactoring #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce feed field count checking before list elements access. We have experienced IndexErrors with this parser, but couldn't locate the source of the problem regarding feed formats. These changes should be sufficient enough for tracing back the source and deals with IndexErrors.
Codecov Report
@@ Coverage Diff @@
## develop #1396 +/- ##
===========================================
- Coverage 76.5% 76.49% -0.02%
===========================================
Files 312 312
Lines 14194 14195 +1
Branches 1882 1884 +2
===========================================
- Hits 10859 10858 -1
- Misses 2919 2920 +1
- Partials 416 417 +1
|
|
@wagner-certat, should you wish to add some more tests: the error messages in logs were generated by lines like these (example from the modified new bot on 2019-04-01: |
Minor code refactor, move variable initialization outside the 'parse_line' function.
Teebor-Choka
force-pushed
the
dataplane_parser_fix
branch
from
023732b to
371b344
Compare
ghost
self-assigned this
ghost
self-requested a review
ghost
approved these changes
Apr 4, 2019
ghost
pushed a commit
that referenced
this pull request
Apr 4, 2019
changelog test with broken entry
|
Thanks, I added a test case for the broken line. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce feed field count checking before list elements access.
We have experienced IndexErrors with this parser, but couldn't locate the source of the problem regarding feed formats. These changes should be sufficient enough for tracing back the source and deals with IndexErrors.