SQLBot draft #1448
Closed
SQLBot draft #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using SQL connection in a bot can be now more generic. PostgreSQL connection, execution and exception handling code was duplicated. Now, I've pulled it to the PostgreSQLBot that can be inherited instead and that inherits SQLBot. Like that, we may easily adopt for example SQLite engine.
Codecov Report
@@ Coverage Diff @@
## develop #1448 +/- ##
===========================================
- Coverage 75.53% 75.51% -0.02%
===========================================
Files 335 337 +2
Lines 16283 16293 +10
Branches 2230 2229 -1
===========================================
+ Hits 12299 12304 +5
- Misses 3489 3495 +6
+ Partials 495 494 -1
|
this commit should be squashed later, this is just a draft
Cool work, definitely appreciated :) |
ghost
added
component: bots
component: core
feature
|
Thanks, I'll do some changes and let you know :) |
ghost
reviewed
Sep 10, 2019
| @@ -1005,6 +1006,9 @@ | |||
| "PostgreSQL": { | |||
| "description": "PostgreSQL is the bot responsible to send events to a PostgreSQL Database. When activating autocommit, transactions are not used: http://initd.org/psycopg/docs/connection.html#connection.autocommit", | |||
| "module": "intelmq.bots.outputs.postgresql.output", | |||
| "help": { | |||
There was a problem hiding this comment.
I'm not sure if we really want to have the help for parameters in that file. (#757 proposes some major steps in how parameters are handled including types and docs/help.)
There was a problem hiding this comment.
Yeah, sorry, that's definitely not part of this PR, I've just wondered how to implement help description to the Manager and been designing some ways... Then I discovered #757 and other and saw that nothing is decided yet and gave up :D
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OUTDATED: Using SQL connection in a bot can be now more generic. PostgreSQL connection, execution and exception handling code was duplicated. Now, I've pulled it to the PostgreSQLBot that can be inherited instead and that inherits SQLBot.
Like that, we may easily adopt for example SQLite engine which is heavily used in CSIRTMalta workflow.
Could you take look at it please and tell me what design fails you see or that it's alright and I may develop further and do some SQLite bots?
UPDATE: This PR is a draft (just take a look at the code, tests fails due to not be edited yet).
lib/bot.pythat handles connection to relational databases – PostgreSQL and SQLite (heavily used in CSIRTMalta workflow). Now, I had two options. Either make a separate expert and output for every relational database (so that user can add "PostgreSQLOutput", "PostgreSQLLookupExpert", "SQLiteOutput", "SQLiteLookupExpert") or make a generic expert and generic output. I've chosen the latter.What do you think? That way, we may easily adopt any DB our users need.