-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sieve: expression negation, nested if / mixed conditionals and actions, support for non-strings in add/add!/update #1923
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1923 +/- ##
===========================================
+ Coverage 75.15% 75.56% +0.40%
===========================================
Files 400 406 +6
Lines 21516 21937 +421
Branches 2874 2924 +50
===========================================
+ Hits 16170 16576 +406
- Misses 4674 4679 +5
- Partials 672 682 +10
|
Wow, great work! I'm just missing the docs :D
I have no problems with breaking changes
|
Some small adjustments, like dropping the negation tests on list/set actions. I will add the breaking changes in a seperate PR, this is enough for one PR as is. |
@wagner-certat Thoughts? |
Thank you very much - again!
We had public holidays yesterday (and sometimes I may be busy :) ) |
changelog entry added in 7ca54fb |
This PR has three parts:
add
,add!
andupdate
support non-string (bool/int/float) valuesThere is also an RFC-ish last commit, with some somewhat breaking changes.
!~
and:notcontains
) are removed:in
is used for list inclusion checks instead of==
:containsany
and:regexin
for string matching against multiple regexes or string inclusions)The last commit is not expected to be accepted at the moment. It'll break a bunch of stuff. Though comments on it would be appreciated.