Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API collector: Optionally use UNIX sockets instead of TCP sockets, fix #1986 #1987

Merged
3 commits merged into from
Jun 17, 2021

Conversation

monoidic
Copy link
Contributor

The first commit adds the option of using UNIX sockets instead of TCP sockets for the API collector, which has performance benefits, and the second fixes an issue with the collector if the collector is reloaded.

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #1987 (ecbd082) into develop (80e87ef) will increase coverage by 0.04%.
The diff coverage is 43.47%.

❗ Current head ecbd082 differs from pull request most recent head bac3d09. Consider uploading reports for the commit bac3d09 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1987      +/-   ##
===========================================
+ Coverage    75.80%   75.85%   +0.04%     
===========================================
  Files          416      416              
  Lines        22228    22249      +21     
  Branches      2952     2942      -10     
===========================================
+ Hits         16850    16876      +26     
+ Misses        4698     4697       -1     
+ Partials       680      676       -4     
Impacted Files Coverage Δ
intelmq/__init__.py 53.57% <ø> (ø)
...lmq/bin/intelmq_generate_misp_objects_templates.py 0.00% <ø> (ø)
intelmq/bin/intelmq_psql_initdb.py 65.57% <ø> (ø)
intelmq/bin/intelmqctl.py 12.88% <ø> (ø)
intelmq/bin/intelmqdump.py 18.30% <ø> (ø)
intelmq/bin/rewrite_config_files.py 0.00% <ø> (ø)
...ntelmq/bots/collectors/alienvault_otx/collector.py 42.42% <ø> (ø)
intelmq/bots/collectors/amqp/collector_amqp.py 73.07% <ø> (ø)
...q/bots/collectors/blueliv/collector_crimeserver.py 48.14% <ø> (ø)
...mq/bots/collectors/calidog/collector_certstream.py 46.15% <ø> (ø)
... and 399 more

@ghost ghost self-requested a review June 11, 2021 10:04
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots feature Indicates new feature requests or new features labels Jun 11, 2021
@ghost ghost added this to the 3.0.0 milestone Jun 11, 2021
@ghost ghost requested review from a user and removed request for a user June 17, 2021 15:36
@ghost ghost self-assigned this Jun 17, 2021
@ghost ghost merged commit 75f5c98 into certtools:develop Jun 17, 2021
ghost pushed a commit that referenced this pull request Jun 17, 2021
@ghost
Copy link

ghost commented Jun 17, 2021

Thanks again @monoidic !

waldbauer-certat pushed a commit that referenced this pull request May 31, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots feature Indicates new feature requests or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants