Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core fixes #2027

Merged
2 commits merged into from
Aug 9, 2021
Merged

Core fixes #2027

2 commits merged into from
Aug 9, 2021

Conversation

monoidic
Copy link
Contributor

@monoidic monoidic commented Aug 9, 2021

This PR fixes two issues:

  • bot_debugger attempts to access a bot's private destination_queues attribute, despite it being public now
  • changes in the passing of pipeline parameters made the load_balance parameter not work

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #2027 (5303764) into develop (fc3abe4) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop    #2027      +/-   ##
===========================================
+ Coverage    76.06%   76.07%   +0.01%     
===========================================
  Files          425      425              
  Lines        22825    22824       -1     
  Branches      3024     3023       -1     
===========================================
+ Hits         17361    17364       +3     
+ Misses        4757     4754       -3     
+ Partials       707      706       -1     
Impacted Files Coverage Δ
intelmq/lib/bot_debugger.py 20.52% <0.00%> (ø)
intelmq/lib/pipeline.py 64.70% <85.71%> (+0.89%) ⬆️

@ghost ghost added this to the 3.0.1 milestone Aug 9, 2021
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: core labels Aug 9, 2021
@ghost ghost self-requested a review August 9, 2021 15:06
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit ee8d505 into certtools:develop Aug 9, 2021
@ghost
Copy link

ghost commented Aug 9, 2021

Cherry-picked in maintenance for the next bugfix release.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants