Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds for XMPP bots #2048

Merged
1 commit merged into from
Aug 19, 2021
Merged

Remove workarounds for XMPP bots #2048

1 commit merged into from
Aug 19, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 18, 2021

XMPP based bots were removed in 3.0.0

XMPP based bots were removed in 3.0.0
@codecov-commenter
Copy link

Codecov Report

Merging #2048 (d8c90b6) into develop (ff7d835) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2048      +/-   ##
===========================================
- Coverage    75.98%   75.66%   -0.32%     
===========================================
  Files          428      428              
  Lines        23002    22696     -306     
  Branches      3062     3058       -4     
===========================================
- Hits         17477    17173     -304     
+ Misses        4817     4814       -3     
- Partials       708      709       +1     
Impacted Files Coverage Δ
intelmq/lib/bot.py 62.32% <ø> (+0.26%) ⬆️
intelmq/bots/experts/cymru_whois/_lib.py 17.02% <0.00%> (-5.76%) ⬇️
intelmq/bots/experts/abusix/_lib.py 36.84% <0.00%> (-3.16%) ⬇️
intelmq/bots/experts/modify/expert.py 92.00% <0.00%> (-2.67%) ⬇️
intelmq/tests/bots/collectors/rt/test_collector.py 75.00% <0.00%> (-2.50%) ⬇️
intelmq/tests/bots/experts/wait/test_expert.py 48.00% <0.00%> (-2.00%) ⬇️
intelmq/tests/bots/experts/uwhoisd/test_expert.py 60.00% <0.00%> (-1.91%) ⬇️
intelmq/bots/parsers/eset/parser.py 74.35% <0.00%> (-1.84%) ⬇️
intelmq/tests/bots/experts/lookyloo/test_expert.py 60.86% <0.00%> (-1.64%) ⬇️
intelmq/tests/bots/experts/abusix/test_expert.py 56.66% <0.00%> (-1.40%) ⬇️
... and 237 more

@ghost ghost marked this pull request as ready for review August 18, 2021 07:33
@ghost ghost self-requested a review August 18, 2021 07:34
@ghost ghost added this to the 3.1.0 milestone Aug 18, 2021
@ghost ghost added the component: bots label Aug 18, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some similar workaround is maybe needed for the n6stomp collector and output, but we'd need to validate that first.

@ghost ghost merged commit d0370e1 into develop Aug 19, 2021
@ghost ghost deleted the schacht/drop-xmpp-leftover branch August 19, 2021 08:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant