IDF: Fix and enforce field name restrictions #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
@@ Coverage Diff @@
## develop #2059 +/- ##
========================================
Coverage 76.03% 76.04%
========================================
Files 428 428
Lines 23040 23048 +8
Branches 3083 3084 +1
========================================
+ Hits 17519 17527 +8
Misses 4813 4813
Partials 708 708
|
ghost
force-pushed
the
wagner/fix-1807
branch
3 times, most recently
from
f0e0538 to
f7208e9
Compare
ghost
approved these changes
Aug 23, 2021
added 6 commits
August 23, 2021 14:29
the regular expression, which is used to check the validity of harmonization key names, was never effective as the dot wasn't escaped. Additionally, the characters of the first element were not allowed to repeat. Pre-compile the regular expression on module loading instead of every instanciation.
if they match the regular expression for key names fixes #1807
fix some used field names, as the field name restrictions are now enforced
a used field name did not match the field name restrictions causing a test error the current version of this feed does not have field anymore, so no futher action is required here
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/message: fix and pre-compile data format key regex
the regular expression, which is used to check the validity of
harmonization key names, was never effective as the dot wasn't escaped.
Additionally, the characters of the first element were not allowed to
repeat.
add github action for regexploit
Pre-compile the regular expression on module loading instead of every instantiation.
check also extra field names
update two affected bots
plus documentation