Update _config.py #2060
Update _config.py #2060
Conversation
Shadowserver parser config update to fix the error when parsing due to existing configuration on the config file, shadow server added some new feeds, so when trying to parse them the bot stops because the configuration does not exit yet on the current config, so, this update is to add the missing configuration.
Co-authored-by: Wagner <[email protected]>
Co-authored-by: Wagner <[email protected]>
| @@ -2833,6 +2962,7 @@ def scan_exchange_identifier(field): | |||
| ('Accessible-MS-RDPEUDP', 'scan_msrdpeudp', accessible_msrdpeudp), | |||
| ('Accessible-Radmin', 'scan_radmin', accessible_radmin), | |||
| ('Accessible-RDP', 'scan_rdp', accessible_rdp), | |||
| ('Accessible-RDPEUDP', 'scan_rdpeudp', accessible_rdp_eudp), | |||
There was a problem hiding this comment.
What is actually the difference to the Accessible-MS-RDPEUDP feed, which we already have and is linked 4 lines above here?
There was a problem hiding this comment.
The first one is Microsoft RDPUDP feed, what happened was that shadowserver changed the name of the feed and did not publish it, so, what im going to do now its to remove the old one, leave the new and comment it with the URL of the feed information until shadow server update their portal.
There was a problem hiding this comment.
because the filename was changed, the bot was not working, so now I just leaved the new one.
There was a problem hiding this comment.
Okay, but then we don't need to create a completely new duplicate mapping. And removing the old entry prevents parsing older reports automatically.
There was a problem hiding this comment.
i see, i will fix it now
There was a problem hiding this comment.
this is what i did, because the only thing that change was the file name, i leaved only one mapping that work for both files names for the feed the old and the new, its that fine?
Shadowserver parser config update to fix the error when parsing due to existing configuration on the config file, shadow server added some new feeds, so when trying to parse them the bot stops because the configuration does not exit yet on the current config, so, this update is to add the missing configuration. closes #2060 Co-Authored by Sebastian Wagner <[email protected]>
|
As of all the 175 lines in the diff only one was relevant (the fixed MSRDPUDP filename), I only took that one change (attributed to your name of course) in 7f663a5. Will be part of the upcoming 3.0.1 release. Thanks for your efforts! |
ghost
closed this
ghost
mentioned this pull request
Shadowserver parser config update to fix the error when parsing due to existing configuration on the config file, shadow server added some new feeds, so when trying to parse them the bot stops because the configuration does not exit yet on the current config, so, this update is to add the missing configuration.