Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: filter: handle empty string not_after & not_before #2075

Merged
1 commit merged into from
Aug 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2021

if any of these two parameters contained empty strings, the bot
initialization failed

fixes #2074

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots labels Aug 27, 2021
@ghost ghost added this to the 3.0.1 milestone Aug 27, 2021
@ghost ghost self-requested a review August 27, 2021 08:14
@ghost ghost self-assigned this Aug 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #2075 (6634984) into maintenance (81750ef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           maintenance    #2075      +/-   ##
===============================================
+ Coverage        76.03%   76.05%   +0.01%     
===============================================
  Files              426      427       +1     
  Lines            22873    22886      +13     
  Branches          3045     3045              
===============================================
+ Hits             17392    17405      +13     
  Misses            4777     4777              
  Partials           704      704              
Impacted Files Coverage Δ
intelmq/bots/experts/filter/expert.py 73.78% <100.00%> (ø)
...ots/experts/filter/test_empty_string_parameters.py 100.00% <100.00%> (ø)

if any of these two parameters contained empty strings, the bot
initialization failed

fixes #2074
@ghost ghost force-pushed the wagner/fix-2074 branch from bdc5548 to 6634984 Compare August 30, 2021 06:36
@ghost ghost merged commit 6634984 into maintenance Aug 30, 2021
@ghost ghost deleted the wagner/fix-2074 branch August 30, 2021 06:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant