FIX: performance issue because of re-loading harmonization file #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldbauer-certat
added
bug
waldbauer-certat
force-pushed
the
fix-2098
branch
2 times, most recently
from
278e755 to
c674949
Compare
waldbauer-certat
force-pushed
the
fix-2098
branch
from
c674949 to
4e2039c
Compare
Codecov Report
@@ Coverage Diff @@
## maintenance #2106 +/- ##
============================================
Coverage 76.05% 76.05%
============================================
Files 427 427
Lines 22886 22886
Branches 3045 3045
============================================
Hits 17405 17405
Misses 4777 4777
Partials 704 704
|
ghost
added this to the
waldbauer-certat
force-pushed
the
fix-2098
branch
3 times, most recently
from
7f5615a to
65f199b
Compare
As of now each new message re-loads the actual harmonization conf, which unfortuneatly results in a high CPU drain. This commit adds the harmonization parameter to the function call, so the harmonization is loaded from the internal python memory allocated space & no more file read/write has to be done. Fixes #2098 Signed-off-by: Sebastian Waldbauer <[email protected]>
waldbauer-certat
force-pushed
the
fix-2098
branch
from
65f199b to
adfa219
Compare
ghost
approved these changes
Sep 9, 2021
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The harmonization file had been loaded within each new report, this nearly kills the CPU, because it has to open the file, parse the file & load it in the memory.