Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: lib/bots: fix names of private attributes #2109

Merged
1 commit merged into from
Sep 10, 2021
Merged

bug: lib/bots: fix names of private attributes #2109

1 commit merged into from
Sep 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 9, 2021

Make private members __is_multithreadable and __collector_empty_process protected members _is_multithreadable and _collector_empty_process to make them easily modifiable by Bot classes

fixes #2108

Make private members `__is_multithreadable` and `__collector_empty_process` protected members `_is_multithreadable` and `_collector_empty_process` to make them easily modifiable by Bot classes

fixes #2108
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots component: core labels Sep 9, 2021
@ghost ghost added this to the 3.0.2 milestone Sep 9, 2021
@ghost ghost requested a review from waldbauer-certat September 9, 2021 18:11
@codecov-commenter
Copy link

Codecov Report

Merging #2109 (0e7dd2a) into maintenance (d396543) will decrease coverage by 0.32%.
The diff coverage is 93.33%.

@@               Coverage Diff               @@
##           maintenance    #2109      +/-   ##
===============================================
- Coverage        76.04%   75.72%   -0.33%     
===============================================
  Files              427      427              
  Lines            22887    22585     -302     
  Branches          3046     3043       -3     
===============================================
- Hits             17405    17102     -303     
+ Misses            4778     4777       -1     
- Partials           704      706       +2     
Impacted Files Coverage Δ
intelmq/lib/bot.py 62.08% <80.00%> (+0.03%) ⬆️
intelmq/bots/collectors/api/collector_api.py 53.33% <100.00%> (ø)
intelmq/bots/collectors/stomp/collector.py 37.14% <100.00%> (ø)
intelmq/bots/experts/splunk_saved_search/expert.py 20.75% <100.00%> (ø)
intelmq/bots/experts/threshold/expert.py 84.61% <100.00%> (ø)
intelmq/bots/outputs/file/output.py 49.35% <100.00%> (-0.65%) ⬇️
intelmq/bots/outputs/misp/output_api.py 24.00% <100.00%> (-0.76%) ⬇️
intelmq/bots/outputs/misp/output_feed.py 58.69% <100.00%> (-0.88%) ⬇️
intelmq/bots/outputs/tcp/output.py 31.57% <100.00%> (ø)
intelmq/bots/outputs/udp/output.py 41.86% <100.00%> (ø)
... and 245 more

@ghost ghost merged commit 5c91a8c into maintenance Sep 10, 2021
@ghost ghost deleted the fix-2108 branch September 10, 2021 06:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots component: core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants