Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new shadowserver files to _config.py #2134

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Added new shadowserver files to _config.py #2134

merged 4 commits into from
Jan 10, 2022

Conversation

mateodurante
Copy link
Contributor

Added new shadowserver event types and files to _config.py:

  • Accesible AMQP
  • Device Identification
  • SSL Poodle IPv6

@mateodurante
Added new shadowserver files to _config.py
07fea1c 
Added new shadowserver event types and files to _config.py:
- Accesible AMQP
- Device Identification
- SSL Poodle IPv6
sebix
sebix requested changes Jan 5, 2022
View reviewed changes
Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good semantically, if someone can verify the validity of the mapping and also the file names against real-world data, it's good to merge. Tests would be cool, but not strictly required.

@sebix sebix added component: bots feature Indicates new feature requests or new features labels Jan 5, 2022
mateodurante
mateodurante commented Jan 5, 2022
View reviewed changes
Copy link
Contributor Author

@mateodurante mateodurante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I have made the proposed changes, if not, please let me know

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #2134 (747100f) into develop (7c1ab88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2134   +/-   ##
========================================
  Coverage    75.93%   75.93%           
========================================
  Files          440      440           
  Lines        23628    23630    +2     
  Branches      3439     3439           
========================================
+ Hits         17941    17943    +2     
  Misses        4956     4956           
  Partials       731      731
Impacted Files Coverage Δ
intelmq/bots/parsers/shadowserver/_config.py 98.75% <100.00%> (+0.01%) ⬆️

@sebix sebix self-assigned this Jan 10, 2022
@sebix sebix added this to the 3.1.0 milestone Jan 10, 2022
@sebix sebix merged commit bfcdbad into certtools:develop Jan 10, 2022
@sebix
Copy link
Member

sebix commented Jan 10, 2022

Thanks again @mateodurante

Documentation update in #2135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebix sebix sebix approved these changes

@waldbauer-certat waldbauer-certat waldbauer-certat approved these changes

Assignees

@sebix sebix

Labels
component: bots feature Indicates new feature requests or new features
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mateodurante @codecov-commenter @sebix @waldbauer-certat