Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intelmqsetup: Fix #2197 #2198

Merged
merged 2 commits into from
Jul 7, 2022
Merged

intelmqsetup: Fix #2197 #2198

merged 2 commits into from
Jul 7, 2022

Conversation

wagner-intevation
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (cef39c1) to head (d7ced2e).
Report is 659 commits behind head on develop.

Files with missing lines Patch % Lines
intelmq/bin/intelmqsetup.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2198      +/-   ##
===========================================
- Coverage    76.34%   76.30%   -0.04%     
===========================================
  Files          441      441              
  Lines        23649    23649              
  Branches      3739     3739              
===========================================
- Hits         18054    18046       -8     
- Misses        4858     4864       +6     
- Partials       737      739       +2     
Files with missing lines Coverage Δ
intelmq/bin/intelmqsetup.py 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@sebix sebix requested a review from waldbauer-certat June 29, 2022 13:28
@sebix sebix added this to the 3.1.0 milestone Jun 29, 2022
@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: core labels Jun 29, 2022
@sebix sebix self-assigned this Jun 29, 2022
The version of the intelmq_api is available under a different path
@wagner-intevation
Copy link
Contributor Author

Fixed the PR number in the changelog in the last push

@sebix sebix merged commit 3b15e09 into develop Jul 7, 2022
@sebix sebix deleted the fix-2197 branch July 15, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intelmqsetup accesses version of intelmq_api wrongly leading to crash
4 participants