Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Removed Python 3.6 from CI #2281

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

kamil-certat
Copy link
Contributor

Our Github Action runners do not have Python 3.6
any more. To unblock building CI, this version
was removed.

This PR is intended to unlock CI. Fully dropping
the Python 3.6 is an another work to do.

Our Github Action runners do not have Python 3.6
any more. To unblock building CI, this version
was removed.
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #2281 (fc8baa4) into develop (dfb0daa) will increase coverage by 0.61%.
The diff coverage is 98.12%.

@@             Coverage Diff             @@
##           develop    #2281      +/-   ##
===========================================
+ Coverage    76.30%   76.92%   +0.61%     
===========================================
  Files          454      454              
  Lines        23991    24120     +129     
  Branches      3782     3516     -266     
===========================================
+ Hits         18307    18554     +247     
+ Misses        4939     4793     -146     
- Partials       745      773      +28     
Impacted Files Coverage Δ
intelmq/bots/experts/abusix/_lib.py 40.00% <50.00%> (ø)
intelmq/bots/experts/cymru_whois/_lib.py 22.77% <50.00%> (ø)
intelmq/lib/harmonization.py 87.21% <95.83%> (ø)
intelmq/bin/intelmqdump.py 42.85% <100.00%> (+24.55%) ⬆️
intelmq/bots/experts/reverse_dns/expert.py 84.12% <100.00%> (+0.25%) ⬆️
intelmq/lib/utils.py 73.13% <100.00%> (+0.77%) ⬆️
intelmq/tests/bin/test_intelmqdump.py 100.00% <100.00%> (ø)
intelmq/tests/lib/test_utils.py 99.51% <100.00%> (+0.03%) ⬆️
intelmq/tests/lib/test_exceptions.py 95.65% <0.00%> (-4.35%) ⬇️
intelmq/bots/experts/modify/expert.py 94.66% <0.00%> (-2.67%) ⬇️
... and 4 more

@waldbauer-certat
Copy link
Contributor

@sebix Please remove 3.6 as required. Thanks

@sebix
Copy link
Member

sebix commented Dec 7, 2022

@aaronkaplan Can you please remove the 3.6 tests from the list of required checks (in the settings of the repo)? Only the admin of the repository can do that.

That blocks currently all other PRs as well.

Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine for the CI-part, but 3.6 also needs to be removed on several other places, e.g. setup.py, the docs (user/installation) and explained in NEWS

@aaronkaplan
Copy link
Member

aaronkaplan commented Dec 7, 2022 via email

@aaronkaplan
Copy link
Member

yup. Tomorrow...

On 07.12.2022, at 21:27, Sebastian @.***> wrote: @aaronkaplan Can you please remove the 3.6 tests from the list of required checks (in the settings of the repo)? Only the admin of the repository can do that. That blocks currently all other PRs as well. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

DONE

@aaronkaplan aaronkaplan merged commit 07e194f into certtools:develop Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants