FIX: Ensure rejecting URLs starting with space #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gh-102153 change in CPython modified how urllib.pare handles URLs with the leading spaces. To ensure previous behaviour, additional check was added. Closes: certtools#2377
sebix
added
bug
sebix
approved these changes
Jun 21, 2023
Without pinning the version, codespell is regulary failing after releasing their new version with new dictionary.
kamil-certat
force-pushed
the
fix_validating_url
branch
from
fd413b5 to
3ee7a3f
Compare
More restrict validation in urllib causes troubles when processing invalid URLs. The correct solution on our side is at the moment unclear, see certtools#2382
|
@sebix Could you take a look, if after my last changes you still approve the PR? |
sebix
requested changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gh-102153 change in CPython modified how
urllib.pare handles URLs with the leading
spaces. To ensure previous behaviour, additional
check was added.
Closes: #2377