Extend intelmq_psql_initdb #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those changes improves the capabilities of the database schema creation. It's now easier to switch to the TimescaleDB or use partitioning in PostgreSQL. Creating scripts can be generated from the harmonisation, as previously just the most basic version. If requested, creation commands get IF NOT EXISTS or OR REPLACE directives to allow re-runing script.
kamil-certat
added
support
component: contrib
feature
sebix
requested changes
Sep 5, 2023
There was a problem hiding this comment.
Great to see that my design is still useful :)
Is the file contrib/eventdb/separate-raws-table.sql obsoleted?
https://intelmq.readthedocs.io/en/develop/user/eventdb.html#separating-raw-values-in-postgresql-using-view-and-trigger needs an update for the new method.
Co-authored-by: Sebastian <[email protected]>
|
Thanks for catching lack of docs, let's see now |
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>
|
@sebix Would you find time to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added creating view for separating raws, optional partitioning key,
custom harmonization file path and
if not exists/or replaceclauses.Those changes improves the capabilities of the database
schema creation. It's now easier to switch to the TimescaleDB
or use partitioning in PostgreSQL. Creating scripts can be
generated from the harmonisation, as previously just the most
basic version. If requested, creation commands get IF NOT EXISTS
or OR REPLACE directives to allow re-runing script.