chore: add preinst script unit tests 🧪
#3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLA-759 Write unit tests for preinst scripts
We could for example create a Docker image with dummy code and config inside and run the script against it to check it performs as expected |
Codecov Report
@@ Coverage Diff @@
## main #3942 +/- ##
======================================
- Coverage 73% 72% -0%
======================================
Files 367 366 -1
Lines 56041 56789 +748
Branches 56041 56789 +748
======================================
+ Hits 40632 40952 +320
- Misses 13344 13751 +407
- Partials 2065 2086 +21 see 39 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tomjohnburton
approved these changes
Sep 6, 2023
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
* chore: add `preinst` script unit tests 🧪 * chore: test refactored preinst script in development * fix: `#DEBHELPER#`tag * debug: use bash as the preinst interpreter * chore: add CI for bats tests 🦇 * fix: set shell to bash * chore: remove `exit 0` * chore: colorful logs 🌈 * chore: add engine preinst tests 🤝 * chore: add placeholder for updating engine config tests
dandanlen
pushed a commit
that referenced
this pull request
Sep 6, 2023
* chore: add `preinst` script unit tests 🧪 * chore: test refactored preinst script in development * fix: `#DEBHELPER#`tag * debug: use bash as the preinst interpreter * chore: add CI for bats tests 🦇 * fix: set shell to bash * chore: remove `exit 0` * chore: colorful logs 🌈 * chore: add engine preinst tests 🤝 * chore: add placeholder for updating engine config tests
syan095
added a commit
that referenced
this pull request
Sep 8, 2023
…on-integration * origin/main: fix: scale encoding skip phantom data (#3967) chore: make platform team code owner of CI settings.toml and localnet (#3957) fix: prefer finalize_signed_extrinsic in engine (#3956) fix: CanonicalAssetPair encoding issue (#3958) chore(bouncer): Update sdk to 0.0.40 (#3945) fix: tweak cli generate-keys output (#3943) chore: add `preinst` script unit tests 🧪 (#3942) Better LP/Broker API RPC Errors (#3931) fix: update substrate ref to use Kademlia fix (#3941) doc: update funding readme with redemption restrictions (#3914) feat: PRO-474 broadcast safe mode (#3902) feat: more forgiving dot address parsing (#3938) fix: duplicate logging (#3939) feat: new lp interface (#3886) # Conflicts: # Cargo.lock # state-chain/cf-integration-tests/Cargo.toml # state-chain/cf-integration-tests/src/authorities.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preinstscripts 🔬/bin/bashas an interpreter 🗣️