feat: add FoK config items to cf_swapping_environment
#5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgmaxim
approved these changes
Aug 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5099 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 442 442
Lines 76766 76643 -123
Branches 76766 76643 -123
======================================
- Hits 54609 54415 -194
- Misses 19236 19291 +55
- Partials 2921 2937 +16 ☔ View full report in Codecov by Sentry. |
kylezs
approved these changes
Aug 1, 2024
syan095
added a commit
that referenced
this pull request
Aug 5, 2024
…at/solana-call-length * origin/feat/solana-ccm-checker: (23 commits) CCM checker returns the decoded cf_param to avoid duplicate decoding. chore: set upgrade test back to true Chore/fix compile (#5109) Chore/bouncer add cf parameters check (#5107) chore: Solana engine not require tx history (#5095) chore: update client for type missmatch chore: update to solana+fok client fix: migrations feat: emit swap request first (#5102) feat: add FoK config items to `cf_swapping_environment` (#5099) chore: add Solana missing rpc return values (#5100) test: Bouncer Fill or Kill test (#5056) feat: put solana chain state Feat: solana engine broadcast retries (#5093) feat: Allow arbitrary accounts to be used as affiliate broker (#5097) Tests for minimum deposit (#5087) feat: apicall stores signer, store current on chain key (#5063) task scope soundness comment (#5096) Swapping Pallet Redesign (#5025) chore: update test ... # Conflicts: # state-chain/cf-integration-tests/src/solana.rs # state-chain/chains/src/sol/api.rs # state-chain/runtime/src/lib.rs
martin-chainflip
pushed a commit
that referenced
this pull request
Aug 5, 2024
* feat: add FoK config items to environment rpc * test: update environment snapshot
martin-chainflip
pushed a commit
that referenced
this pull request
Aug 5, 2024
* feat: add FoK config items to environment rpc * test: update environment snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1517
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Breaking change: This PR changes the
SwappingEnvironmentstruct. I am unsure of how this will affect the frontend.added
swap_retry_delay_blocksandmax_swap_retry_duration_blocksto thecf_swapping_environment.max_swap_retry_duration_blocksis a hashmap of the setting value for each chain.Updated the
environment_serializationsnapshot.