-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Multiple Parse Options support Stage1b - Add parseConfig to forms response and service models #242
Conversation
- Added optional parseConfig field to OptionChoice and BaseQuestion models - Updated form service and sprint service to include parseConfig in select queries - Extended FormResponseDto to support parseConfig with validation - Added example configurations for icon, boolean, and scale question types
Yes, I agree that its better to keep it just |
I think if needed, we can do something like this, parseConfig: {
type: "scale" // could use an enum for this, the type could indicate what values it has
min: 0,
.... I also noticed just now, most example have no "value" but some has a "value" key. Should we standardize it? |
- Added optional parseConfig to MeetingFormResponse - Updated sprint service and controller test files to include parseConfig - Added parseConfig to mock data and service query selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Looks good on swagger ✅
Ran all tests locally ✅
Description
Added support for adding the
parseConfig
field to fetching of form questions configuration, along with flexibility. This new optional field allows for additional configuration parameters to be stored for different question types, such as:In addition, A new wiki page was created called Form Input types v2
The changes include:
parseConfig
field toOptionChoice
andBaseQuestion
classesIssue link
Fixes # 86b3u7ygj
Type of change
How Has This Been Tested?
The changes have been tested through:
Checklist: