Replace the design system with local source files #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
release
yannbf
force-pushed
the
fix/replace-design-system
branch
from
2f5efdd to
6b38611
Compare
yannbf
commented
Feb 1, 2024
| MutableRefObject, | ||
| } from 'react'; | ||
| import { styled, css } from '@storybook/theming'; | ||
| import { WithTooltip, TooltipMessage } from '@storybook/components'; |
There was a problem hiding this comment.
This was changed from
import { WithTooltip, TooltipMessage } from '@storybook/design-system';and I do not know whether there is a big difference, whether this will break or not. Please test it well
There was a problem hiding this comment.
This may have had a minor impact: https://www.chromatic.com/review?appId=6480e1b0042842f149cfd74c&number=171&type=linked&view=changes
- Sorry for the noisy diff; prettier ran too
- The previous template string styles allowed some bad patterns, mixing static and dynamic styles and indescriminately overwriting styles for a selector
- When converting those styles to JS objects, I unwittingly copied those patterns, which now caused issues
- To fix
- I separated (where reasonable) static and dynamic (those that depend on `props`) styles into multiple style arguments
- I ensured that all top-level selector object keys are only ever in the styles once and all of the conditionality happens within
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at fixing the issue, this time with a bit more harsh measure: copy the files used from
@storybook/design-system, and get rid of the dependency altogether (for now at least)Turns out this fixed the issue and it runs OK on a project:
But there are consequences locally that caused CI failures and such.
👉 Please make sure to test the canary really well before merging
📦 Published PR as canary version:
1.0.3--canary.171.b614185.0✨ Test out this PR locally via: