-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a UI state for an error on the first build #95
Add a UI state for an error on the first build #95
Conversation
AP-3621 Improve first build error handling
I hit a number of issues when creating my first build for test baselines:
Some of these issues may exist not in the onboarding build creation scenario as well. |
9233087
to
be34a5c
Compare
75fcc38
to
03e43fe
Compare
@jonniebigodes any suggestion on the best place the link should go? This is when the Chromatic build errors somewhere, probably most likely the SB build itself. @MichaelArestad suggested https://www.chromatic.com/docs/setup/#troubleshooting |
@tmeasday I'm ok with it for now, as the errors are similar for each case. However, as feedback continues to roll in, I'm more than ok with updating the documentation and setting up a section, possibly named "Debugging Tests", with some additional information and instructions on debugging it. I'm more than glad to update the addon to reflect that change. Sounds good? |
…ests into tom/ap-3621-improve-first-build-error-handling
contents = ( | ||
<> | ||
<ErrorContainer> | ||
<b>Build failed:</b> <code>{firstError?.message || "Unknown Error"}</code>{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, we want the originalError instead of the formattedError so that users see more information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. @tmeasday I had trouble reproducing this. For the case in the ticket (running a build in a repo with only one commit) now creates a new build with auto-accepted stories. Is there another cli build error you've used to test it?
@weeksling hmm, yes we tweaked the CLI to allow single commit repos from the addon. You could try a repo with no commits at all (not no git setup at all, that will trigger a different issue 😉 ). It's a while ago now, I think I figured out some |
Got it, thanks! @tmeasday this formatting looks a bit off, but it looks like both the originalError and the formattedError contain the same content. I think we should \ remove the unneeded characters in the error message for the |
@MichaelArestad I wasn't sure if there is a component I could use here.
Also I am not sure exactly where this should link to?
📦 Published PR as canary version:
0.0.99--canary.95.19f15a6.0
✨ Test out this PR locally via: